label artifact version and feature selection in CI #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukoneck
requested review from
dvush,
ZanCorDX,
ferranbt,
liamaharon and
metachris
as code owners
metachris
reviewed
Dec 4, 2024
| @@ -102,13 +108,13 @@ jobs: | |||
| - name: Upload rbuilder artifact | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: rbuilder-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }} | |||
| name: rbuilder-${{ needs.extract-version.outputs.VERSION }}-${{ matrix.configs.target }}${{ matrix.features && '-' }}${{ matrix.features }} | |||
There was a problem hiding this comment.
this results in such filenames:
rbuilder-workflows-release-version-6725aee-aarch64-unknown-linux-gnu-redact-sensitive
why is the workflows-release-version useful? this seems to be added by this change 🤔
There was a problem hiding this comment.
no strong feelings. I dropped it, updated run here.
ferranbt
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
allow specifying compilation features and add version to artifact names in release workflow.
✅ I have completed the following steps:
successful run: https://github.com/flashbots/rbuilder/actions/runs/12154595107